Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cast data_index as size_t in cuda_row_data to avoid integer overflow #5706

Merged
merged 1 commit into from
Feb 11, 2023
Merged

cast data_index as size_t in cuda_row_data to avoid integer overflow #5706

merged 1 commit into from
Feb 11, 2023

Conversation

SiNZeRo
Copy link
Contributor

@SiNZeRo SiNZeRo commented Feb 9, 2023

related to #5705

@shiyu1994

@shiyu1994
Copy link
Collaborator

@SiNZeRo Thanks. Rerun the ci job to pass the randomly failed setting.

@jameslamb jameslamb added the fix label Feb 11, 2023
@jameslamb
Copy link
Collaborator

I've manually re-triggered CI, will merge this when it is successful.

@SiNZeRo does this FIX #5705 for you? Can we close that issue when this is merged?

@jameslamb jameslamb merged commit e4dc238 into microsoft:master Feb 11, 2023
@SiNZeRo
Copy link
Contributor Author

SiNZeRo commented Feb 11, 2023

yes, this PR is intended to resolve this issue.

@jameslamb
Copy link
Collaborator

great, thank you

@jameslamb jameslamb mentioned this pull request Feb 11, 2023
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SiNZeRo @shiyu1994 @jameslamb @guolinke