Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove Visual Studio 2017 CI job for R-package #5079

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

StrikerRUS
Copy link
Collaborator

Closed #4748.

Related: #5059.

Sorry, I missed in #5059 the point that GitHub Actions shares the same environments with Azure Pipelines.
actions/runner-images#4312
actions/runner-images#5238

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! That's my fault, sorry I missed that!

Could the Visual Studio 2019 MSVC job be changed to r_version: 3.6? So that we still have coverage of building for R 3.6 with MSVC?

@StrikerRUS
Copy link
Collaborator Author

@jameslamb Great point, thanks! Done in 779b007.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@jameslamb
Copy link
Collaborator

closing and re-opening to re-trigger CI. I'm not sure why GitHub Actions didn't run.

@jameslamb jameslamb closed this Mar 17, 2022
@jameslamb jameslamb reopened this Mar 17, 2022
@StrikerRUS
Copy link
Collaborator Author

Woohoo!!! Finally they did it! 🚀
https://github.blog/2022-03-16-save-time-partial-re-runs-github-actions/
Just found this blog post in my news feed.

@jameslamb jameslamb merged commit eb686a7 into master Mar 17, 2022
@jameslamb jameslamb deleted the remove_vs2017_r_job branch March 17, 2022 03:58
@jameslamb
Copy link
Collaborator

Woohoo!!! Finally they did it! 🚀

ahhhh excellent! That's really exciting.

@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows-2016 Azure Pipelines environment is deprecated
2 participants