Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] clarify that categorical features will be converted to integers internally #4959

Merged
merged 6 commits into from
Feb 20, 2022

Conversation

jmoralez
Copy link
Collaborator

@jmoralez jmoralez commented Jan 18, 2022

Emphasizes that categorical features will be converted to int internally, to avoid the confusion that they should be provided as integers in the input data, as was asked in #4932. Also adds information on what will happen if negative values are found.

Here's how that section looks like:
image

Closes #4932.

@StrikerRUS
Copy link
Collaborator

I think there are more places where this clarification should be made for the consistency in docs. See #1567 for example.

@shiyu1994
Copy link
Collaborator

Close and reopen to retrigger ci tests.

@StrikerRUS
Copy link
Collaborator

@jmoralez I'm very sorry, I just merged #5009 and only after doing that I noticed that these two PRs conflict with each other. Could you please resolve conflicts?

@jmoralez
Copy link
Collaborator Author

Haha no worries

@shiyu1994
Copy link
Collaborator

@jmoralez Thank you for doing this. Could you please rerun this script (https://github.com/microsoft/LightGBM/blob/master/helpers/parameter_generator.py)
so that the changes in config.h can be reflected on the documentation files.
Changes in the documentation files should also be updated to this branch to pass the static checks.

@jmoralez
Copy link
Collaborator Author

Thanks @shiyu1994. I didin't know I had to change the config.h file. Done in 349f797.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments below:

docs/Advanced-Topics.rst Outdated Show resolved Hide resolved
docs/Parameters.rst Outdated Show resolved Hide resolved
include/LightGBM/config.h Outdated Show resolved Hide resolved
python-package/lightgbm/basic.py Show resolved Hide resolved
python-package/lightgbm/engine.py Show resolved Hide resolved
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clarification!

@shiyu1994 shiyu1994 merged commit 820ae7e into microsoft:master Feb 20, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[questions] How to properly deal with categorical variables
4 participants