-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][R-package] Update the explanation of num_threads (fixes #4192) #4199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this!
Sorry I didn't check earlier, but there are two other places with this same bit of documentation. Can you please update these as well?
Line 48 in 69d02e3
#' \item{\code{num_threads}: Number of threads for LightGBM. For the best speed, set this to LightGBM/R-package/R/lgb.train.R
Line 21 in 69d02e3
#' \item{\code{num_threads}: Number of threads for LightGBM. For the best speed, set this to
@jameslamb Sure, will do that, but just wonder what's the difference between LightGBM/lightgbm_r and LightGBM/R-package? I know the latter is the r package but what's the lightgbm_r? That folder has the same three files lgb.cv.R, lgb.train.R, and lightgbm.R |
Oh sure, I can explain. The R package wraps C/C++ code stored in To do that, the R build scripts (
Let me know if you have other questions! We'd love to have you contribute more to the R package in the future of you're interested, and understanding this setup might help you do that. |
Thank you for the explanation! Yes, I would like to add some contributions to the LGBM if I could! :) I will ask if I have some questions related to the package! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks very much!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Hi @jameslamb
Here is the PR related to the issue #4192. Please check out the update!
Best,
Issac