Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] document CUDA version support #3428

Merged
merged 6 commits into from
Jan 31, 2021
Merged

[docs] document CUDA version support #3428

merged 6 commits into from
Jan 31, 2021

Conversation

StrikerRUS
Copy link
Collaborator

In follow up of #3160.

Closed #3416.

cc @ChipKerchner

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this! I left a few suggestions on clarifying the language, but otherwise I agree with these changes.

docs/Installation-Guide.rst Outdated Show resolved Hide resolved
docs/Installation-Guide.rst Outdated Show resolved Hide resolved
docs/Installation-Guide.rst Show resolved Hide resolved
docs/Parameters.rst Outdated Show resolved Hide resolved
include/LightGBM/config.h Outdated Show resolved Hide resolved
python-package/README.rst Show resolved Hide resolved
python-package/README.rst Show resolved Hide resolved
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for this!

@guolinke guolinke mentioned this pull request Oct 26, 2020
@StrikerRUS StrikerRUS changed the title [docs] document CUDA version support [WIP][docs] document CUDA version support Nov 3, 2020
@StrikerRUS
Copy link
Collaborator Author

Depends on fixing CUDA error reported in #3450 and #3424 (comment).

@bordaw
Copy link

bordaw commented Dec 17, 2020

Do you know when the official LightGBM documentation will be updated to describe the CUDA support?

@StrikerRUS
Copy link
Collaborator Author

@bordaw Right after fixing critical bugs of the initial CUDA implementation: #3428 (comment). Unfortunately, it seems that it won't be very quickly: #3160 (comment).

@bordaw
Copy link

bordaw commented Dec 17, 2020

Thanks for the prompt response! Please let me know if I can help in the fix as I am one of the original authors of the CUDA implementation.

@StrikerRUS
Copy link
Collaborator Author

@bordaw Wow, this will be just awesome! Thank you very much for wishing to help!

I think you can try to reproduce the issue locally first: #3160 (comment). Please let me know if you need any additional details.

@bordaw
Copy link

bordaw commented Dec 18, 2020

Thanks! Will download the latest code and take a look..

@StrikerRUS StrikerRUS mentioned this pull request Jan 28, 2021
@StrikerRUS StrikerRUS changed the title [WIP][docs] document CUDA version support [docs] document CUDA version support Jan 28, 2021
@StrikerRUS
Copy link
Collaborator Author

@jameslamb @guolinke Please (re-)review when have time.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no changes to suggest, this looks good to me. Thanks for adding the explanation on how the CUDA build is different from OpenCL and why you might use it. Really helpful.

@StrikerRUS StrikerRUS merged commit 8040ef9 into master Jan 31, 2021
@StrikerRUS StrikerRUS deleted the cuda_doc branch January 31, 2021 14:08
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traning model on multi GPUs?
3 participants