-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Sort indices in lgb.cv() (fixes #2503) #2524
Conversation
Sorry, don't have R environment to confirm the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work correctly here.
@jameslamb did you check these ? Lines 235 to 239 in b4bb38d
for the indices in weight and init_score. |
ping @jameslamb @Laurae2 again |
@guolinke I did not. Looking... |
@jameslamb |
@jameslamb Any updates? |
@StrikerRUS @guolinke sorry for the delay! I've opened #2572 to track this, so we can have the discussion in an open issue instead of in a comment on a closed PR. I have a PR to fix this coming momentarily. |
@jameslamb Thanks! I was worrying that this issue can be lost in the closed PR. |
This PR attempts to fix the issue reported by @rgranvil in #2503 . You can confirm by building the R package from this branch and running the sample code provided in that issue.
I effectively just mirrored what was done on the Python side in #2510 .