-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support AppleClang with openmp #1501
Conversation
Oh, I didn't know AppleClang has supported OpenMP. Good news! |
travis-ci says:
It seems installing gcc on macos exceed ci timeout. |
master fails too :( Travis problems... again! UPD: VSTS macOS builds are running more than one hour too. So I suppose the problem is in brew. |
There is something wrong with OSX on Travis.
|
For issue tracking: |
Travis seems to be OK now. Rerunning builds. |
CMakeLists.txt
Outdated
@@ -24,7 +24,7 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | |||
message(FATAL_ERROR "Insufficient Clang version") | |||
endif() | |||
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang") | |||
message(FATAL_ERROR "AppleClang isn't supported. Please see https://github.com/Microsoft/LightGBM/blob/master/docs/Installation-Guide.rst#macos") | |||
cmake_minimum_required(VERSION 3.12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to move this to the top of the file where other cmake_minimum_required
are listed?
@levyfan , could you also help with the updating of Documents? |
docs/Installation-Guide.rst
Outdated
Apple Clang | ||
*********** | ||
|
||
1. Install `CMake`_ (3.12 or higher). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be nice if the certain version of AppleClang been specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very certain about the minimal version. I know
macOS >= el_capitan is supported by https://github.com/Homebrew/homebrew-core/blob/master/Formula/libomp.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reasonable guess would be 9.0 (since 10.12).
I think we could update the Travis for macOS to using AppleClang as default. I' ll create related PR |
Don't it too early, because CMake 3.12 is Release Candidate now? I mean, can we install it via brew at Travis? |
@StrikerRUS we could use brew --HEAD for cmake now and switch to stable release later. |
Why is |
support #1492
Tested with cmake 3.12.0-rc3 and Apple LLVM version 9.1.0 (clang-902.0.39.2) and libomp 5.0.1.
Howto
brew install libomp