-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible install from sources with pip and localized Visual Studio #874
Comments
After the close look at |
@StrikerRUS Thanks. |
@guolinke I understand your position about CMake and I don't suggest to replace CMake+VS building by sln+VS. I suggest to add this method on Windows: if sln+VS fails go to CMake+VS. What do you think? |
@StrikerRUS yeah, you can rewriting. you can try the "sln+VS" first. |
@guolinke |
@StrikerRUS |
* disabled logs from compilers; fixed #874 * fixed safe clear_fplder * added windows folder to manifest.in * added windows folder to build * added library path * added compilation with MSBuild from .sln-file * fixed unknown PlatformToolset returns exitcode 0 * hotfix * updated Readme * removed return * added installation with mingw test to appveyor * let's test appveyor with both VS 2015 and VS 2017; but MinGW isn't installed on VS 2017 image * fixed built-in name 'file' * simplified appveyor * removed excess data_files * fixed unreadable paths * separated exceptions for cmake and mingw * refactored silent_call * don't create artifacts with VS 2015 and mingw * be more precise with python versioning in Travis * removed unnecessary if statement * added classifiers for PyPI and python versions badge * changed python version in travis * added support of scikit-learn 0.18.x * added more python versions to Travis * added more python versions to Appveyor * reduced number of tests in Travis * Travis trick is not needed anymore * attempt to fix according to #880 (comment)
* disabled logs from compilers; fixed #874 * fixed safe clear_fplder * added windows folder to manifest.in * added windows folder to build * added library path * added compilation with MSBuild from .sln-file * fixed unknown PlatformToolset returns exitcode 0 * hotfix * updated Readme * removed return * added installation with mingw test to appveyor * let's test appveyor with both VS 2015 and VS 2017; but MinGW isn't installed on VS 2017 image * fixed built-in name 'file' * simplified appveyor * removed excess data_files * fixed unreadable paths * separated exceptions for cmake and mingw * refactored silent_call * don't create artifacts with VS 2015 and mingw * be more precise with python versioning in Travis * removed unnecessary if statement * added classifiers for PyPI and python versions badge * changed python version in travis * added support of scikit-learn 0.18.x * added more python versions to Travis * added more python versions to Appveyor * reduced number of tests in Travis * Travis trick is not needed anymore * attempt to fix according to #880 (comment)
It's impossible to install LightGBM with
pip
on Windows machine with localized Visual Studio.Log:
It's known
pip
bug. And it is caused by logs that are produced by Visual Studio with Russian (I suppose any non-English) localization (if MinGW was localized it would cause installation fail too).I had the same problem in my project and successfully solved it by shutting up logs from compilers. To be more precise by changing
os.system()
calls tosubprocess.check_output()
.If you guys do not mind described solution I can create a PR.
The text was updated successfully, but these errors were encountered: