Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [docs] readthedocs configuration options are deprecated #4954

Closed
jameslamb opened this issue Jan 16, 2022 · 4 comments · Fixed by #4957
Closed

[ci] [docs] readthedocs configuration options are deprecated #4954

jameslamb opened this issue Jan 16, 2022 · 4 comments · Fixed by #4957

Comments

@jameslamb
Copy link
Collaborator

jameslamb commented Jan 16, 2022

Description

This project uses readthedocs to build and host its documentation at https://lightgbm.readthedocs.io/en/latest/.

The way those docs are built is configured here:

version: 2
formats:
- pdf
python:
version: 3
install:
- requirements: docs/requirements.txt
sphinx:
builder: html
configuration: docs/conf.py
fail_on_warning: true
submodules:
include: all
recursive: true

According to the documentation for that service, some of the configuration options used in this project's .readthedocs.yaml are deprecated.

python.version (link)

This option is now deprecated and replaced by build.tools.python. See python.version (legacy) for the description of this option.

According to https://docs.readthedocs.io/en/stable/config-file/v2.html#python-version-legacy, using version: 3 is also deprecated.

Make sure to use quotes (") to make it a string. We previously supported using numbers here, but that approach is deprecated.

Additional Comments

These deprecated configuration should be removed, so that documentation builds don't break when those features are removed in future changes to the readthedocs service.

Given the discussion in #4948, I think this should be accomplished by switching the project's readthedocs builds to use mamba, as documented at "Making builds faster with mamba" (RTD docs link).

@jameslamb
Copy link
Collaborator Author

@akshitadixit
Copy link
Contributor

Hi @jameslamb is this available to work on?

@jameslamb
Copy link
Collaborator Author

Thanks for your interest @akshitadixit ! But no, #4957 (linked above) is already addressing this.

StrikerRUS added a commit that referenced this issue Feb 19, 2022
* [ci] [docs] use mamba for readthedocs builds (fixes #4954)

* update docs

* simplify build script and add docs flag to gitignore

* exit with non-0 if build fails

* update CI job

* add doxygen

* remove outdated requirement_base.txt reference

* use conda create instead of conda env create

* fix conda create flags

* add nodefaults to env.yml

* Update docs/README.rst

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* try to fix check-docs CI job

* additional changes

* switch from mamba to miniforge

* simplify docker command and fix issues in local build script

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* update docs and conda

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants