-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] CMake errors in MinGW builds on Windows #3060
Comments
I just tried removing the extra mingw on PATH, per #2965 (comment), and I don't think that solved it. You can see the changes I made at https://github.com/jameslamb/LightGBM/pull/23/files and the corresponding build in AppVeyor at https://ci.appveyor.com/project/jameslamb/lightgbm/builds/32764241/job/cve3wk1f8obtw6q5 |
I found one StackOverflow answer suggesting that the message can be suppressed by installing Just to test, I installed mingw-get-setup.exe and used it to install |
cmake has a one time stopper if it finds any sh.exe in PATH, specifically it has an hardcoded MinGW one time stopper in cmake (intentional known issue on cmake end). To circumvent it, cmake has to be ran twice. It keeps in cache the previous cmake run hence should not introduce major slowdown, however for users it will print a lot of unnecessary text and an unnecessary cmake error. There is currently no workaround other than having a very recent cmake version. See the following cmake commit which lifts the one time stopper: https://gitlab.kitware.com/cmake/cmake/-/commit/82ddcf0db1d220564145122c3cce25d25ee0e254 (Nov 2, 2019). (I could document better the workaround/reason here: 3421bc6#diff-473c89bfc9641f554ac12d37ebc3d377R61) + link to #664 (comment) |
Thanks very much for the extra context! I saw comments in the code about running I think we could close this issue just by adding a note to the R FAQs telling people they can safely ignore the errors https://lightgbm.readthedocs.io/en/latest/FAQ.html#r-package |
Closed via #3078. |
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
See the most recent build on
master
. There are some errors being generated when building the R package using MinGW. This isn't causing any user-facing issues as far as I know, since it doesn't cause installation to fail, but we should fix these warnings so that they don't waste users' time or lead to unnecessary bug reports.This StackOverflow post suggested that maybe putting MinGW on
PATH
can fix this but so far I haven't had luck with it.The text was updated successfully, but these errors were encountered: