Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct FeatureEvaluationEvent schema #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhiyuanliang-ms
Copy link
Contributor

@zhiyuanliang-ms zhiyuanliang-ms commented Jan 14, 2025

The expected value of Enabled property should be "True"/"False"

Centralized testcase: ref
.NET implementation: ref
Note in C#, calling ToString on a boolean true will produce "True"

JS implementation: ref

Python implementation: in python boolean are born True and False

@mrm9084
Copy link
Contributor

mrm9084 commented Jan 14, 2025

We need to verify we have the correct answer for this as we have this PR. #22. @rossgrambo

@zhiyuanliang-ms
Copy link
Contributor Author

@mrm9084 The telemetry.enabled property in the feature flag configuration should be boolean. It doesn't relate to the FeatureEvaluationEvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants