Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code review change for PPM/PFM code #548

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Minor code review change for PPM/PFM code #548

merged 3 commits into from
Nov 7, 2024

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Nov 6, 2024

If you gave it a nullptr for the filename, it would return a Win32 result of "ERROR_PATH_NOT_FOUND". Makes more sense to early-out as an E_INVALIDARG.

Includes a few more minor tweaks for where invalid args should be returned.

@walbourn walbourn self-assigned this Nov 6, 2024
@walbourn walbourn added the tools Applies to texconv, texdiag, texassemble, etc. label Nov 6, 2024
@walbourn walbourn merged commit 2f37de7 into main Nov 7, 2024
83 checks passed
@walbourn walbourn deleted the codereview branch November 7, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Applies to texconv, texdiag, texassemble, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants