Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const error check for object subscript operator #3580

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix const error check for object subscript operator #3580

merged 2 commits into from
Mar 17, 2021

Conversation

tex3d
Copy link
Contributor

@tex3d tex3d commented Mar 15, 2021 •
edited
Loading

  • Fix const error check for object subscript operator
  • update tests and VerifierHelper.py

Fixes #3572

@tex3d tex3d requested a review from vcsharma March 15, 2021 06:23
@tex3d tex3d mentioned this pull request Mar 15, 2021
Closed
@AppVeyorBot
Copy link

✅ Build DirectXShaderCompiler 1.0.4558 completed (commit c4a7038b06 by @tex3d)

@tex3d tex3d requested a review from dmpots March 16, 2021 15:23
vcsharma
vcsharma approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@vcsharma vcsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tex3d tex3d merged commit de00b01 into microsoft:master Mar 17, 2021
@tex3d tex3d deleted the fix-const-subscript branch March 17, 2021 18:50
tex3d added a commit to tex3d/DirectXShaderCompiler that referenced this pull request Mar 22, 2021
@tex3d
Fix const error check for object subscript operator (microsoft#3580)
6590576 
(cherry picked from commit de00b01)
@tex3d tex3d mentioned this pull request Mar 23, 2021
Merged
tex3d added a commit that referenced this pull request Mar 23, 2021
@tex3d
Merge fixes to release branch (#3611)
3d5e8b9 
Cherry-pick changes to release branch:
cd3ef21 Roll back llvm::ArrayRef dependency in ExecutionTest (#3613)
2791c51 Generate descriptions for resources with no names (#3598)
22fa209 Fix LifetimeIntrinsicTest issues (#3609)
2039610 Fix Dxil validator compat and test issues (#3610)
220e884 Rename payload qualifier field to not match type (#3607)
0e89206 Correct exception handler sprintf for 32-bit (#3608)
9b475a7 Add dxc exception handler (#3604)
e8372b9 Fixed arg pairs not correct for old source in module pdbs (#3599)
2bda44f Add constant evaluation for clamp() (#3581)
640c9af Added way for caller to replace args in PDB utils (#3595)
de00b01 Fix const error check for object subscript operator (#3580)
@tex3d tex3d mentioned this pull request Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcsharma vcsharma vcsharma approved these changes

@dmpots dmpots Awaiting requested review from dmpots

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing compile error
3 participants
@tex3d @AppVeyorBot @vcsharma