Avoid trying to get disubprogram without debug MD #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to fixup line numbers when inlining a function, if the call instruction had no debug location, the DIsubprogram was queried. That query took a very long time and was pointless when there is no debug info. The code now checks for debug metatdata before trying to get the disubprogram Fixes microsoft#3130
|
@adam-yang wrote this code, I don't think I'll feel comfortable submitting this unless he looks it over |
|
✅ Build DirectXShaderCompiler 1.0.4361 completed (commit a9edbe1c2f by @pow2clk) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fixup line numbers when inlining a function, if the call
instruction had no debug location, the DIsubprogram was queried. That
query took a very long time and was pointless when there is no debug
info.
The code now checks for debug metatdata before trying to get the
disubprogram
Fixes #3130