Skip to content

Commit

Permalink
Reword misleading type buffer atomic error message (#3268)
Browse files Browse the repository at this point in the history
Saying that typed buffers are not supported is inaccurate. Scalar types
are required for it to work though.
  • Loading branch information
pow2clk authored Nov 19, 2020
1 parent 753e2a4 commit 471e0ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/HLSL/HLOperationLower.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7304,7 +7304,7 @@ void TranslateDefaultSubscript(CallInst *CI, HLOperationLowerHelper &helper, HL
// Invalid operations.
Translated = false;
dxilutil::EmitErrorOnInstruction(
userCall, "Atomic operation on typed buffer is not supported.");
userCall, "Typed resources used in atomic operations must have a scalar element type.");
return;
} break;
default:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// RUN: %dxc -E main -T cs_6_0 %s | FileCheck %s

// CHECK: Atomic operation on typed buffer is not supported
// CHECK: Typed resources used in atomic operations must have a scalar element type

RWBuffer<uint4> bufA;

Expand Down

0 comments on commit 471e0ae

Please sign in to comment.