for now, do not permit non-library-profile blobs with a CompilerVersi…

…on part.
microsoft · Jul 3, 2023 · 27a63e2 · 27a63e2
1 parent 68d38a7
commit 27a63e2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/HLSL/DxilValidation.cpp b/lib/HLSL/DxilValidation.cpp
@@ -5731,13 +5731,16 @@ HRESULT ValidateDxilContainerParts(llvm::Module *pModule,
       VerifyFeatureInfoMatches(ValCtx, GetDxilPartData(pPart), pPart->PartSize);
       break;
     case DFCC_CompilerVersion:
-      // Either this blob is a PDB, or it is a library with shader model at least 6.8
+      // This blob is either a PDB, or a library profile
       if (ValCtx.isLibProfile) {
         if (!ValidateCompilerVersionPart((void *)GetDxilPartData(pPart), pPart->PartSize))
         {
-            ValCtx.EmitFormatError(ValidationRule::ContainerPartInvalid, { szFourCC });
+          ValCtx.EmitFormatError(ValidationRule::ContainerPartInvalid, { szFourCC });
         }
       }
+      else {
+        ValCtx.EmitFormatError(ValidationRule::ContainerPartInvalid, { szFourCC });
+      }
       break;
 
     case DFCC_RootSignature: