Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bloom custom ckpt files, improved model path support, MII refactor, flake8, etc. #43

Merged
merged 20 commits into from
Jul 29, 2022
Merged

Bloom custom ckpt files, improved model path support, MII refactor, flake8, etc. #43

merged 20 commits into from
Jul 29, 2022

Conversation

jeffra
Copy link
Contributor

@jeffra jeffra commented Jul 25, 2022 •
edited
Loading

  • Task specific request_dict parsing, ensures required keys are given for each task type.
  • Support appending model_path and aml model path in aml deployments
  • Pass checkpoint dict to ds-inference instead of writing to file
  • Add flake8 pre-commit and associated fixes
  • Big refactor of overall code structure

Requires DeepSpeed version that includes this: microsoft/DeepSpeed#2132

mrwyattii
mrwyattii suggested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@mrwyattii mrwyattii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

mii/deployment.py Show resolved Hide resolved
mii/models/load_models.py Outdated Show resolved Hide resolved
@jeffra jeffra changed the title task specific parsing in score file Bloom custom ckpt files, improved model path support, MII refactor, flake8, etc. Jul 28, 2022
mrwyattii
mrwyattii reviewed Jul 28, 2022
View reviewed changes
mii/config.py Outdated Show resolved Hide resolved
mii/utils.py Outdated Show resolved Hide resolved
mii/utils.py Show resolved Hide resolved
mii/utils.py Outdated Show resolved Hide resolved
@jeffra jeffra merged commit 7a1544d into aml Jul 29, 2022
@jeffra jeffra deleted the task-specific-score branch July 29, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrwyattii mrwyattii mrwyattii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffra @mrwyattii