Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast abi consumption #998

Merged
merged 17 commits into from
Feb 24, 2022
Merged

Fast abi consumption #998

merged 17 commits into from
Feb 24, 2022

Conversation

ujjwalchadha
Copy link
Contributor

@ujjwalchadha ujjwalchadha commented Sep 21, 2021 •
edited
Loading

This PR enables fast abi consumption in cswinrt as per #182

For quick reference, here is the test idl and the corresponding generated code

Note: Although this builds and passes the current tests, this request is only for code design review at the moment and should not be merged before adding some more testing.

@manodasanW
Copy link
Member

It would be interesting to see if we can get some benchmarks to see what the diff we see as is with and without the fastabi attribute for essentially the same class.

manodasanW
manodasanW reviewed Sep 23, 2021
View reviewed changes
src/cswinrt/helpers.h Outdated Show resolved Hide resolved
@kennykerr kennykerr requested a review from dunhor September 23, 2021 21:42
Scottj1s
Scottj1s reviewed Jan 18, 2022
View reviewed changes
src/cswinrt/helpers.h Outdated Show resolved Hide resolved
@Scottj1s
Copy link
Member

oops - lost code_writers.h on iteration 7

Scottj1s
Scottj1s reviewed Feb 4, 2022
View reviewed changes
src/cswinrt/helpers.h Outdated Show resolved Hide resolved
@ujjwalchadha ujjwalchadha force-pushed the ujjwalchadha/fast_abi_consumption branch from 74d5880 to 46f972f Compare February 17, 2022 00:58
@ujjwalchadha ujjwalchadha force-pushed the ujjwalchadha/fast_abi_consumption branch from 46f972f to 3fb3477 Compare February 17, 2022 02:50
manodasanW
manodasanW reviewed Feb 23, 2022
View reviewed changes
src/cswinrt/helpers.h Outdated Show resolved Hide resolved
@ujjwalchadha ujjwalchadha force-pushed the ujjwalchadha/fast_abi_consumption branch from b04507f to ed48c48 Compare February 24, 2022 02:23
@ujjwalchadha ujjwalchadha merged commit 765ae46 into master Feb 24, 2022
@angelazhangmsft angelazhangmsft linked an issue Feb 24, 2022 that may be closed by this pull request
Perf: Minimize QueryInterface calls, implement FastABI (Consumption) #182
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scottj1s Scottj1s Scottj1s left review comments

@manodasanW manodasanW manodasanW approved these changes

@BenJKuhn BenJKuhn Awaiting requested review from BenJKuhn

@j0shuams j0shuams Awaiting requested review from j0shuams

@kennykerr kennykerr Awaiting requested review from kennykerr

@dunhor dunhor Awaiting requested review from dunhor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perf: Minimize QueryInterface calls, implement FastABI (Consumption)
3 participants
@ujjwalchadha @manodasanW @Scottj1s