Ujjwalchadha/fix value type caching 2 #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Aug 30, 2021
manodasanW
reviewed
Aug 30, 2021
ujjwalchadha
commented
Aug 30, 2021
manodasanW
reviewed
Aug 31, 2021
manodasanW
reviewed
Aug 31, 2021
manodasanW
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Implementation looks good to me.
Can you also add calls to CreateReferenceCachingFactory for the
if (runtimeClassName == "Windows.Foundation.IReference`1<String>")and
if (runtimeClassName == "Windows.Foundation.IReference`1<Windows.UI.Xaml.Interop.TypeName>")cases above? We'll need this check there as well to cover all cases.
manodasanW
reviewed
Aug 31, 2021
| @@ -312,11 +324,11 @@ private static bool IsIReferenceArray(Type implementationType) | |||
| // PropertySet and ValueSet can return IReference<String> but Nullable<String> is illegal | |||
| if (runtimeClassName == "Windows.Foundation.IReference`1<String>") | |||
| { | |||
| return (IInspectable obj) => new ABI.System.Nullable<String>(obj.ObjRef); | |||
| return CreateReferenceCachingFactory((IInspectable obj) => new ABI.System.Nullable<String>(obj.ObjRef)); | |||
There was a problem hiding this comment.
Technically I think ABI.System.Nullable would have handled keeping the objref alive I think, but this doesn't hurt either.
manodasanW
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the previous fix to value type caching issue.
The actual cause of the issue is: not holding on to the native value type (coming in as IReference or IReferenceArrsy) when it gets stored in the dotnet cache. Thus, the pointer is allowed to be reused before GC cleans it.
We fix it by adding a ConditionalWeakTable which holds on to the native reference until the boxed value is alive. Thus not allowing pointer reuse before it should be.