Check that a class correctly implements its interfaces #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j0shuams correctly pointed out that this is raising an error in the CustomButton test. When the method implementation isn't coming from the class directly, but from one of its base types, the current algorithm still returns null. Will work on this a bit more. |
…IWinRTObject since the interface implementation is explicit and cannot be found by FindImplementationForInterfaceMember
j0shuams
reviewed
Aug 5, 2021
j0shuams
approved these changes
Aug 6, 2021
j0shuams
reviewed
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940