Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support net6 #915

Merged
merged 9 commits into from
Jul 23, 2021
Merged

Support net6 #915

merged 9 commits into from
Jul 23, 2021

Conversation

ujjwalchadha
Copy link
Contributor

This updates CsWinRT to be able to generate .net6 projections when net6.0 is targeted,
This PR also updates other projects to target net6.0 along with net5.0 including WinRT.Runtime and test projects.

@ujjwalchadha ujjwalchadha requested a review from manodasanW July 19, 2021 23:42
@ujjwalchadha ujjwalchadha linked an issue Jul 19, 2021 that may be closed by this pull request
cswinrt doesn't support targeting .net6 #730
Closed
@ujjwalchadha ujjwalchadha changed the title Ujjwalchadha/update to net6 Support net6 Jul 19, 2021
manodasanW
manodasanW reviewed Jul 20, 2021
View reviewed changes
src/build.cmd Outdated Show resolved Hide resolved
@manodasanW
Copy link
Member

Have you looked at enabling authoring, diagnostics, and object lifetime tests for net6 and what it takes?

@ujjwalchadha ujjwalchadha requested a review from manodasanW July 22, 2021 00:34
manodasanW
manodasanW reviewed Jul 22, 2021
View reviewed changes
src/build.cmd Outdated Show resolved Hide resolved
@manodasanW
Copy link
Member

We should make sure the pipeline still builds fine and we update the pipeline for these changes as necessary.

manodasanW
manodasanW reviewed Jul 22, 2021
View reviewed changes
src/build.cmd Outdated Show resolved Hide resolved
@j0shuams
Copy link
Contributor

We will probably need an issue tracking authoring support for net6 as well

CsWinRT/nuget/Microsoft.Windows.CsWinRT.Authoring.Transitive.targets

Line 13 in 72ba46d

<HostingSupport-Net5Dir>$(MSBuildThisFileDirectory)..\lib\net5.0*</HostingSupport-Net5Dir>

@ujjwalchadha ujjwalchadha requested a review from j0shuams July 23, 2021 17:45
j0shuams
j0shuams reviewed Jul 23, 2021
View reviewed changes
src/Benchmarks/Benchmarks.csproj Show resolved Hide resolved
src/Directory.Build.props Show resolved Hide resolved
src/Projections/Directory.Build.props Show resolved Hide resolved
@ujjwalchadha ujjwalchadha merged commit b52b1e6 into master Jul 23, 2021
@ujjwalchadha ujjwalchadha deleted the ujjwalchadha/update_to_net6 branch July 23, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manodasanW manodasanW manodasanW approved these changes

@j0shuams j0shuams j0shuams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cswinrt doesn't support targeting .net6
3 participants
@ujjwalchadha @manodasanW @j0shuams