Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate file from the CsWinRT NuGet package. #909

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

jlaanstra
Copy link
Collaborator

This PR fixes #908 by simply using the Microsoft.Windows.CsWinRT.Authoring.Transitive.targets file from the build folder and removing the one from buildTransitive.

@manodasanW manodasanW requested a review from j0shuams July 13, 2021 01:02
@j0shuams
Copy link
Contributor

Hi @jlaanstra thanks for your consideration! I believe we need the buildTransitive folder, as it is how package reference users will get the custom build logic. A c++ project with a package reference (could be an entry in packages.config and not PackageReference), will not get any assets from the build folder.

I built a nupkg on a branch with your changes, and put it through my tests and the consuming project failed to generate a projection. This leads me to think this PR would break scenarios that currently work.
If you want to do the same tests, let me know and I can give more information. It is based on the "Coords" and "App" projects in my test repo here - https://github.com/j0shuams/HostSupport

@j0shuams j0shuams merged commit d146899 into microsoft:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CsWinRT NuGet includes the buildTransitive folder but doesn't follow the NuGet conventions for it.
2 participants