Fix datapackage to datapackageview invalid cast #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Jul 7, 2021
jkoritzinsky
reviewed
Jul 7, 2021
manodasanW
reviewed
Jul 8, 2021
manodasanW
reviewed
Jul 8, 2021
| ABI.System.Nullable<Type> nt => (T)(object)nt.Value, | ||
| T castRcw => castRcw, | ||
| _ when tryUseCache => CreateRcwForComObject<T>(ptr, false), | ||
| _ => throw new ArgumentException(string.Format("Unable to create rcw. The com object {0} has type {1} which cannot be assigned to type {2}", ptr, rcw.GetType(), typeof(T))) |
There was a problem hiding this comment.
Suggested change
| _ => throw new ArgumentException(string.Format("Unable to create rcw. The com object {0} has type {1} which cannot be assigned to type {2}", ptr, rcw.GetType(), typeof(T))) | |
| _ => throw new ArgumentException(string.Format("Unable to create a wrapper object. The WinRT object {0} has type {1} which cannot be assigned to type {2}", ptr, rcw.GetType(), typeof(T))) | |
manodasanW
approved these changes
Jul 8, 2021
jkoritzinsky
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback while casting the rcw to the managed type using the cache. The fallback is to not use the cache and try creating the rcw again. This takes care of the invalid case where aa different runtime class represents the same object pointer that has been seen before.