Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for out and array params for event source handler #881

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Added support for out and array params for event source handler #881

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea461e
Added support for out and array params for event source handler
ujjwalchadha Jun 17, 2021
685ca48
Updated the invoke argument method
ujjwalchadha Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/cswinrt/code_writers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,12 +455,6 @@ namespace cswinrt
bind<write_parameter_name>(param));
}

void write_projection_arg(writer& w, method_signature::param_t const& param)
{
w.write("%",
bind<write_parameter_name>(param));
}

void write_event_source_type_name(writer& w, type_semantics const& eventTypeSemantics)
{
auto eventTypeCode = w.write_temp("%", bind<write_type_name>(eventTypeSemantics, typedef_name_type::Projected, false));
Expand Down Expand Up @@ -506,7 +500,7 @@ namespace cswinrt

void write_event_invoke_args(writer& w, method_signature const& methodSig)
{
w.write("%", bind_list<write_projection_arg>(", ", methodSig.params()));
w.write("%", bind_list<write_parameter_name_with_modifier>(", ", methodSig.params()));
}

void write_abi_type(writer& w, type_semantics const& semantics)
Expand Down