-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf improvements in CCW creation. #739
Conversation
FYI @jkotas |
@manodasanW I appreciate the following request may be annoying, but would it be possible to get a sense of the raw numbers we are looking at here? Like Scenario A vs Scenario B and then % improvement? Memory used and CPU usage are all that is interesting at the moment. It helps the .NET team talk about the investments we make in APIs and scenarios they unlock. |
I plan on asking Bartek if he can do an updated run of this scenario which he has been tracking for various CsWinRT versions and the previous built-in version. I will also look at getting some metrics for memory usage. |
Perfect. That would be most insightful. Thanks! |
Based on a perf and memory analysis, it can be seen the memory consumption for storing the vtable entries is down as expected and in the repro scenario where CCW creation was found to be expensive, it is no longer near the top of the CPU usage and the execution time of the repro seems to have went down by half.
Fixes #438
Fixes #554