Fix authoring bugs #712
Merged
Fix authoring bugs #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warnings on build via structural change
j0shuams
force-pushed
the
jlarkin/fix-target-bugs
branch
from
d446576
to
567b8c8
Compare
manodasanW
reviewed
Jan 30, 2021
|
When testing with C# apps via package reference, there are some issues with the target framework of the consumer. Although the changes in the PR are aimed at support for native consumers, I won't push for this to merge unless we decide the do c# support in a followup PR |
manodasanW
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our targets that automate dll reference updating were too assumptive in what files would be in the authored nupkg. This PR introduces a filter on the dlls we package with an authored winmd/dll, as well as make some structural changes to remove warnings about the nupkg. Some bugs arose because of the assumption that only CsWinRT related dlls would be on our
reference path when building, when in fact WinUI dlls/assets were being added just by nature of a package reference.
I also found some things to cleanup in WinRTRules
Closes #693 #696 #697