Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported solution configs, make get_testwinrt curdir-independent, assert TestWinRT requirement #706

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

Scottj1s
Copy link
Member

fixes #692

@j0shuams
Copy link
Contributor

I see we are removing Arm and Arm64 -- when I was doing nuget work I know I made sure we included these host dlls. But only if they exist, which made me think eventually we will make these to support arm architectures. I see we are removing those platforms, is the plan to add support for arm{64} in the future or are we sticking with x86/x64?

@Scottj1s
Copy link
Member Author

Scottj1s commented Jan 28, 2021

I see we are removing Arm and Arm64 -- when I was doing nuget work I know I made sure we included these host dlls. But only if they exist, which made me think eventually we will make these to support arm architectures. I see we are removing those platforms, is the plan to add support for arm{64} in the future or are we sticking with x86/x64?

No plans to ever build a cswinrt.exe (or other native components) for ARM32/64. Removing those configs, and Any CPU, prevents confusion for devs when they open the sln

@j0shuams
Copy link
Contributor

I see we are removing Arm and Arm64 -- when I was doing nuget work I know I made sure we included these host dlls. But only if they exist, which made me think eventually we will make these to support arm architectures. I see we are removing those platforms, is the plan to add support for arm{64} in the future or are we sticking with x86/x64?

No plans to ever build a cswinrt.exe (or other native components) for ARM32/64. Removing those configs, and Any CPU, prevents confusion for devs when they open the sln

Does this mean we should update our nuget pipeline / build cmd to not consider winrt.host dlls for arm architectures?

@manodasanW
Copy link
Member

Opened #708 to track ARM64 support for WinRT.Host.

@Scottj1s Scottj1s merged commit 02ee3f4 into master Jan 28, 2021
@Scottj1s Scottj1s deleted the scottj1s/build_helps branch May 5, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cswinrt.sln doesn't build
3 participants