Update Diagnostic rules #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Jan 22, 2021
manodasanW
reviewed
Jan 22, 2021
manodasanW
reviewed
Jan 22, 2021
manodasanW
reviewed
Jan 22, 2021
manodasanW
reviewed
Jan 22, 2021
…w diagnostic identifer (wme -> cswinrt)
j0shuams
force-pushed
the
jlarkin/update-diagnostics
branch
from
715e750
to
0e9c04d
Compare
j0shuams
commented
Jan 22, 2021
| @@ -18,124 +18,125 @@ private static DiagnosticDescriptor MakeRule(string id, string title, string mes | |||
| category: "Usage", | |||
| defaultSeverity: DiagnosticSeverity.Error, | |||
| isEnabledByDefault: true, | |||
| helpLinkUri: "https://docs.microsoft.com/en-us/previous-versions/hh977010(v=vs.110)"); | |||
| helpLinkUri: "https://github.com/microsoft/CsWinRT/tree/master/src/Authoring/WinRT.SourceGenerator/AnalyzerReleases.Unshipped.md"); | |||
There was a problem hiding this comment.
We may want this to be AnalyzerReleases.Shipped.md, but I am not sure when we consider a version of our SourceGenerator analyzer "released"
manodasanW
reviewed
Jan 26, 2021
manodasanW
reviewed
Jan 26, 2021
manodasanW
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new files -- AnalzyerReleases.Unshipped.md and AnalyzerReleases.Shipped.md
These are made from our diagnostic descriptors, and serve as a documentation page for our rules.
I am also changing the "WME" identifier of the rules to be "CsWinRT", which required a change in our diagnostic unit testing app.
I have updated our
.gitignoreas well, as there is a new directory that we don't want to track for our winui packaging sample.closes #676 , addresses part of #677