Add targets for hosting support #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in consuming app
j0shuams
force-pushed
the
jlarkin/nuget-targets
branch
from
6f5bef9
to
512c234
Compare
Scottj1s
reviewed
Jan 13, 2021
Scottj1s
reviewed
Jan 13, 2021
Scottj1s
reviewed
Jan 13, 2021
j0shuams
force-pushed
the
jlarkin/nuget-targets
branch
from
e25a5ad
to
5bb5d2a
Compare
j0shuams
force-pushed
the
jlarkin/nuget-targets
branch
from
8144052
to
6ced889
Compare
manodasanW
reviewed
Jan 14, 2021
manodasanW
reviewed
Jan 14, 2021
manodasanW
reviewed
Jan 14, 2021
manodasanW
reviewed
Jan 14, 2021
manodasanW
reviewed
Jan 14, 2021
manodasanW
reviewed
Jan 15, 2021
manodasanW
reviewed
Jan 15, 2021
manodasanW
approved these changes
Jan 15, 2021
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains a new file in our nuget directory -
Microsoft.Windows.CsWinRT.Authoring.targets. This file handles the binplacement of DLLs needed for hosting authored components. This file is used in changes toMicrosoft.Windows.CsWinRT.targets, introduced in this PR to properly package an authored component. We package theAuthoring.targetsfile asAuthoredComponent.CsWinRT.targetsfor any authored component. Details can be found in the authoring docs (also updated in this pr).For the packaging, I needed to use better paths for the arch-specific dlls (hence the changes to the
CsWinRT.nuspec). This raised issues where references to the WinRt.Host.dll showed up just by a package reference to cswinrt, so I've added reference removals of this for the general case of CsWinRT usage to the targetCsWinRTRemoveHostingDllReferences.Testing
I have been using a C# winrt component in a C++ app and was able to do a successful end-to-end test with this configuration. Link here
Related issues
Closes #474 and part of #663