-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authoring support for C# built-in types to WinRT types #631
Conversation
You probably should disable whitespace diff when reviewing this PR. |
src/Authoring/AuthoringConsumptionTest/AuthoringConsumptionTest.exe.manifest
Show resolved
Hide resolved
</ItemGroup> | ||
|
||
</Project> | ||
<Project Sdk="Microsoft.NET.Sdk"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be moved to the Samples folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably want to rename this to be a test, this component is more for test purposes than to serve as a sample. I will address that in a future PR.
Ideally, the 3 sources of mapping data would derived from a single source. Meantime, can we add comments to all 3 to indicate the other two need to be kept in sync? Line 450 in 1b4ff32
CsWinRT/src/WinRT.Runtime/Projections.cs Line 25 in 1b4ff32
Refers to: src/Authoring/WinRT.SourceGenerator/WinRTTypeWriter.cs:271 in e3f6fd1. [](commit_id = e3f6fd1, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exciting!
54f0504
to
1084263
Compare
Contributes to #309