Fixed removal of dll references that report IsWinmdFile == true #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
approved these changes
Oct 21, 2020
j0shuams
reviewed
Oct 21, 2020
| @@ -27,11 +27,11 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
| <Target Name="CsWinRTRemoveWinMDReferences" BeforeTargets="ResolveReferences;BeforeCompile" AfterTargets="AfterResolveReferences"> | |||
| <ItemGroup> | |||
| <!--Move winmd references into private item group to prevent subsequent winmd reference errors--> | |||
| <CsWinRTRemovedReferences Include="@(ReferencePath)" Condition="'%(ReferencePath.WinMDFile)' == 'true'" /> | |||
| <CsWinRTRemovedReferences Include="@(ReferencePath)" Condition="'%(ReferencePath.Extension)' == '.winmd'" /> | |||
There was a problem hiding this comment.
Is ReferencePath an object with fields WinMDFile and Extension? Or did you change the WinMDFile field to Extension?
|
Not sure I understand the root issue - dlls were getting marked IsWinMDFile=true. Who is doing this, are they winmd files with the wrong extension? If they are not winmd files, doesn't that point to a VS or Net5 problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some references required by csc are inadvertently removed because they record true for being WinMD files, but actually have a DLL extension.