Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support explicitly implementing 'ICustomPropertyProvider' #1841

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Support explicitly implementing 'ICustomPropertyProvider' #1841

merged 4 commits into from
Oct 24, 2024

Conversation

Sergio0694
Copy link
Member

This PR ensures that types explicitly implementing ICustomPropertyProvider work as expected:

  • The user defined implementation is guaranteed to be picked
  • No duplicated vtable entry is added

Also added some tests for this scenario.

@Sergio0694 Sergio0694 added the enhancement New feature or request label Oct 21, 2024
@Sergio0694 Sergio0694 requested a review from manodasanW October 21, 2024 23:29
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/support-explicit-icpp branch 2 times, most recently from 7259fdf to 0c40ef4 Compare October 22, 2024 05:09
@manodasanW manodasanW merged commit 43e8172 into master Oct 24, 2024
10 checks passed
@manodasanW manodasanW deleted the user/sergiopedri/support-explicit-icpp branch October 24, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manodasanW manodasanW manodasanW approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sergio0694 @manodasanW