Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when using funcs and take another approach to escape assembly name #1836

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

manodasanW
Copy link
Member

  • We were previously checking the nested expression to get the parameters. This typically worked before unless it is a func and there was a nested invocation. Fixed to not use the nested ones to get parameters.
  • We previously tried to escape any invalid characters from the assembly name. Given that seems to actually be trickier, change the approach to escape anything not on our valid list.

@manodasanW manodasanW merged commit 445b4f6 into master Oct 18, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/fixfunc branch October 18, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants