Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception messages for failed casts #1826

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Sergio0694
Copy link
Member

This PR improves the exception message for failed Cast<TInterface> calls. Fix following feedback from internal folks.

@Sergio0694 Sergio0694 added the debugging Improvements to debugging experience label Oct 14, 2024
@Sergio0694 Sergio0694 requested a review from manodasanW October 14, 2024 23:49
Copy link

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergio, new error message looks great, would have definitely helped me right away pick up quicker on what was going on with mismatched types between XAML data template and my data structure! 🦙❤️

@manodasanW manodasanW merged commit 938d95f into master Oct 15, 2024
10 checks passed
@manodasanW manodasanW deleted the user/sergiopedri/imporve-cast-exceptions branch October 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugging Improvements to debugging experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants