Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of source generator #1804

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Improve performance of source generator #1804

merged 9 commits into from
Oct 9, 2024

Conversation

manodasanW
Copy link
Member

@manodasanW manodasanW commented Sep 30, 2024 •
edited
Loading

  • Changed the ordering of the properties during the combine operations to allow us to know earlier whether authoring support is enabled. This allows us to reduce how often we call GetVtableAttributesToAddOnLookupTable and thereby reducing calls to GetSymbolInfo. This should reduce the number of calls by half and thereby improve performance.

Sergio0694
Sergio0694 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/Authoring/WinRT.SourceGenerator/Helper.cs Outdated Show resolved Hide resolved
@manodasanW manodasanW merged commit 4bc7bfd into master Oct 9, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/generatoroptimization branch October 9, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manodasanW @Sergio0694