Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable scenarios when xaml asks for type and fix vtable for event handlers #1684

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

manodasanW
Copy link
Member

@manodasanW manodasanW commented Jul 29, 2024

  • PropertyChangedEventHandler and NotifyCollectionChangedEventHandler are both custom type mapped delegates and were missing vtable entries. This adds vtable entries for them along with tests.
  • WinUI has scenarios where it asks to marshal a native type name to a managed type. We are seeing scenarios where WinUI is asking for nullable types and we aren't able to return the actual type given we avoid MakeGenericType on AOT. Typically, this would be fine if this is being round trip to the native side given we are able to return a fake type, but there are scenarios where WinUI is doing an equality check on the type we return to find the entry for it on its managed lookup table. That is failing when we return our fake type. Addressing that for built-in types by adding an explicit check to handle them.

Fixes #1678

@manodasanW manodasanW merged commit d4c8461 into staging/AOT Jul 31, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/nullabletypename branch July 31, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants