Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source generator for exception types and fix is operator #1682

Merged
merged 11 commits into from
Aug 1, 2024

Conversation

manodasanW
Copy link
Member

  • The source generator was generating code when collections of exceptions were used that didn't compile. This was because exception is a class which gets mapped in WinRT to a value type and they don't have all the same functions. This addresses that and also the issue where the exception marshaler functions were also mismatching which ones to use.
  • Also fixing the is operator check when used with collection types whose helper type haven't been registered and is not implemented by the object. Right now, it throws an exception in that scenario when it should just say this object doesn't implement it.
  • Also adding DisposeAbiArray which was missing for Uris

@manodasanW manodasanW merged commit 52280f9 into staging/AOT Aug 1, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/exceptionabitype branch August 1, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants