Improve codegen for merged activation factories #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/refine-merged-factory-codegen
branch
2 times, most recently
from
8adb499
to
a232aef
Compare
manodasanW
approved these changes
Jul 3, 2024
Sergio0694
force-pushed
the
user/sergiopedri/refine-merged-factory-codegen
branch
from
024f4c4
to
7b7c16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues around requiring unsafe code. In particular, it makes the
TryGetDependentActivationFactorymethod be generated only when we actually do have some activation factories, or skipped entirely otherwise. This will allow apps not generating projections in their projects to not have to enable unsafe blocks unnecessarily.