Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESRP signing #1651

Merged
merged 2 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,15 @@ stages:
cultureMappingType: 'None'

# Sign TDBuild Output
- task: EsrpCodeSigning@1
- task: EsrpCodeSigning@5
displayName: ESRP CodeSigning
inputs:
ConnectedServiceName: 81cc6790-027c-4ef3-928d-65e8b96a691a
ConnectedServiceName: $(SigningServiceName)
AppRegistrationClientId: $(SigningAppId)
AppRegistrationTenantId: $(SigningTenantId)
AuthAKVName: $(SigningAKVName)
AuthCertName: $(SigningAuthCertName)
AuthSignCertName: $(SigningSignCertName)
FolderPath: $(LocOutputDir)
Pattern: |
release_x64\de-DE\WinRT.Host.dll.mui
Expand Down
27 changes: 21 additions & 6 deletions build/AzurePipelineTemplates/CsWinRT-PublishToNuget-Stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,15 @@ stages:
copy release_x86\WinRT.Interop.winmd WinRT.Interop.winmd

# ESRP Codesigning
- task: EsrpCodeSigning@1
- task: EsrpCodeSigning@5
displayName: ESRP CodeSigning
inputs:
ConnectedServiceName: 81cc6790-027c-4ef3-928d-65e8b96a691a
ConnectedServiceName: $(SigningServiceName)
AppRegistrationClientId: $(SigningAppId)
AppRegistrationTenantId: $(SigningTenantId)
AuthAKVName: $(SigningAKVName)
AuthCertName: $(SigningAuthCertName)
AuthSignCertName: $(SigningSignCertName)
FolderPath: $(Build.SourcesDirectory)
Pattern: |
cswinrt.exe
Expand Down Expand Up @@ -133,11 +138,16 @@ stages:
]

# ESRP CodeSigning 3rd Party
- task: EsrpCodeSigning@1
- task: EsrpCodeSigning@5
displayName: ESRP CodeSigning 3rd party
continueOnError: True
inputs:
ConnectedServiceName: 81cc6790-027c-4ef3-928d-65e8b96a691a
ConnectedServiceName: $(SigningServiceName)
AppRegistrationClientId: $(SigningAppId)
AppRegistrationTenantId: $(SigningTenantId)
AuthAKVName: $(SigningAKVName)
AuthCertName: $(SigningAuthCertName)
AuthSignCertName: $(SigningSignCertName)
FolderPath: $(Build.SourcesDirectory)
Pattern: |
net6.0\IIDOptimizer\Mono.Cecil.dll
Expand Down Expand Up @@ -223,10 +233,15 @@ stages:
buildProperties: cswinmd_nuget_version=$(NugetVersion);cswinmd_outpath=$(Build.SourcesDirectory)\net6.0\CsWinMD;source_generator=$(Build.SourcesDirectory)\netstandard2.0\WinRT.SourceGenerator.dll

# ESRP CodeSigning
- task: EsrpCodeSigning@1
- task: EsrpCodeSigning@5
displayName: ESRP CodeSigning
inputs:
ConnectedServiceName: 81cc6790-027c-4ef3-928d-65e8b96a691a
ConnectedServiceName: $(SigningServiceName)
AppRegistrationClientId: $(SigningAppId)
AppRegistrationTenantId: $(SigningTenantId)
AuthAKVName: $(SigningAKVName)
AuthCertName: $(SigningAuthCertName)
AuthSignCertName: $(SigningSignCertName)
FolderPath: $(Build.ArtifactStagingDirectory)
Pattern: '*.nupkg'
signConfigType: inlineSignParams
Expand Down
37 changes: 25 additions & 12 deletions build/AzurePipelineTemplates/CsWinRT-Variables.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,30 @@
variables:
MajorVersion: 2
MinorVersion: 0
PatchVersion: 8
WinRT.Runtime.AssemblyVersion: '2.0.0.0'
Net5.SDK.Feed: 'https://dotnetcli.blob.core.windows.net/dotnet'
Net6.SDK.Version: '6.0.415'
NoSamples: 'false'
- group: XlangSigning
- name: MajorVersion
value: 2
- name: MinorVersion
value: 0
- name: PatchVersion
value: 8
- name: WinRT.Runtime.AssemblyVersion
value: '2.0.0.0'
- name: Net5.SDK.Feed
value: 'https://dotnetcli.blob.core.windows.net/dotnet'
- name: Net6.SDK.Version
value: '6.0.415'
- name: NoSamples
value: 'false'

# This 'coalesce' pattern allows the yml to define a default value for a variable but allows the value to be overridden at queue time.
# E.g. '_IsRelease' defaults to empty string, but if 'IsRelease' is set at queue time that value will be used.

_IsRelease: $[coalesce(variables.IsRelease, '')]
_RunBenchmarks: $[coalesce(variables.RunBenchmarks, 'false')]
_DotNetRuntimeVersion: $[coalesce(variables.DotNetRuntimeVersion, '6.0.23')]
_WindowsSdkVersionSuffix: $[coalesce(variables.WindowsSdkPackageVersionSuffix, '25')]
_PublishCsWinMD: $[coalesce(variables.PublishCsWinMD, 'false')]
- name: _IsRelease
value: $[coalesce(variables.IsRelease, '')]
- name: _RunBenchmarks
value: $[coalesce(variables.RunBenchmarks, 'false')]
- name: _DotNetRuntimeVersion
value: $[coalesce(variables.DotNetRuntimeVersion, '6.0.23')]
- name: _WindowsSdkVersionSuffix
value: $[coalesce(variables.WindowsSdkPackageVersionSuffix, '25')]
- name: _PublishCsWinMD
value: $[coalesce(variables.PublishCsWinMD, 'false')]