-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataTransferManger interop APIs #1528
Conversation
#else | ||
public | ||
#endif | ||
static class DataTransferManagerInterop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to add XML docs.
I think for now as long as this new class is similar for the most part to the other interop classes, it is good. These look to be the docs for this interface. I will be retargeting this PR to the staging branch given this is an API surface change and that is our next planned assembly version change. |
Ran CI build. |
Hey this sounds amazing! I would be so happy for this to be properly supported. |
…gerInterop Use IIDataTransferManagerInteropMethods to implement DataTransferManagerInterop. Because IDataTransferManagerInterop COM interfaces are not inherited from IInspectable, but IUnknown
Co-authored-by: Manodasan Wignarajah <manodasan@hotmail.com>
Co-authored-by: Manodasan Wignarajah <manodasan@hotmail.com>
Update src/cswinrt/strings/ComInteropHelpers.cs
@@ -499,33 +499,35 @@ namespace Windows.ApplicationModel.DataTransfer | |||
#endif | |||
static class DataTransferManagerInterop | |||
{ | |||
private static readonly global::System.Guid IDataTransferManagerInterop_IID = new global::System.Guid("3A3DCD6C-3EAB-43DC-BCDE-45671CE800C8"); | |||
private static readonly global::System.Guid IDataTransferManagerInterop_IID = new global::System.Guid(0x3A3DCD6C, 0x3EAB, 0x43DC, 0xBC, 0xDE, 0x45, 0x67, 0x1C, 0xE8, 0x00, 0xC8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong endianess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong, but this uses the format where the values goes as parameters and not in the byte array where we need to flip it for endianness, so I think this is correct right?
I think once the last set of feedback is addressed, we should be good with this change. |
Co-authored-by: Manodasan Wignarajah <manodasan@hotmail.com>
Thanks for this change, will merge once CI is done. |
CI finished and all tests passed. |
Add DataTransferManger interop APIs