Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce binary size in agile reference context cache #1468

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Reduce binary size in agile reference context cache #1468

merged 1 commit into from
Jan 25, 2024

Conversation

Sergio0694
Copy link
Member

Fixes the small size regression from #1466.
We don't actually need the instantiations here at all.
This is exactly the same trick we also used in #1448.

@Sergio0694
Copy link
Member Author

Saves ~35 KB on .NET 9. Along with #1454 we should be back to par after #1466.

image

@Sergio0694 Sergio0694 merged commit 17ecf63 into staging/AOT Jan 25, 2024
9 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/non-generic-agile-cache branch January 25, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manodasanW manodasanW manodasanW approved these changes

@jlaanstra jlaanstra Awaiting requested review from jlaanstra

Assignees
No one assigned
Labels
AOT trimming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sergio0694 @manodasanW