Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Marshaler<T> trimming for blittable types #1455

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Jan 19, 2024

Saves 55 KB on .NET 9:

image

The issue is the linker couldn't follow the flow reading back from the static field, so it always compiling both paths.

@Sergio0694 Sergio0694 requested a review from manodasanW January 19, 2024 18:15
@Sergio0694 Sergio0694 added the performance Related to performance work label Jan 19, 2024
@Sergio0694 Sergio0694 merged commit 329747f into staging/AOT Jan 19, 2024
9 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/marshal-trim-improvement branch January 19, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AOT performance Related to performance work trimming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants