Allow dropping native host for NativeAOT WinRT components #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
enhancement
Sergio0694
commented
Nov 22, 2023
| @@ -1,258 +1,342 @@ | |||
| using Microsoft.CodeAnalysis; | |||
There was a problem hiding this comment.
Note: I normalized whitespaces in this file, review with whitespace diff off.
The actual changes are just a few lines of code being added.
ahmed605
reviewed
Nov 22, 2023
ahmed605
reviewed
Nov 22, 2023
hez2010
suggested changes
Nov 23, 2023
hez2010
suggested changes
Nov 23, 2023
manodasanW
reviewed
Nov 27, 2023
Sergio0694
force-pushed
the
user/sergiopedri/naot-winrt-exports
branch
from
4d5281b
to
38098bf
Compare
Sergio0694
force-pushed
the
user/sergiopedri/naot-winrt-exports
branch
from
fa62a4c
to
f02bf33
Compare
…ot-winrt-exports-authoringtestfixes2
…-authoringtestfixes2 Fix test issues discovered from enabling AOT for authoring scenarios
manodasanW
approved these changes
Jan 9, 2024
|
Just to note in the PR, there is one remaining authoring test failure for AOT (AuthoringTest.CustomTypes). That would be addressed in a separate PR. |
We will still need the generated See: https://github.com/hez2010/WinRTServer/blob/master/WinRTServer/InternalModule.cs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1387
Overview
This PR adds a new
CsWinRTAotExportsEnabledMSBuild property that can be set in authoring scenarios (and is automatically set ifPublishAotis already set). This triggers the generator to emit the native exports for WinRT .dll-s directly into the same binary, with the correct logic, and also skips adding all references and copying all files related to the native host infrastructure.Keeping as a draft as I'm not entirely sure how to set up unit tests for this just yet 😅