Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose api's for Context on ObjectReference. #1391

Merged

Conversation

jlaanstra
Copy link
Collaborator

@jlaanstra jlaanstra commented Nov 18, 2023

This enables extra optimizations for factories as part of #1390 and should also allow us to add a Detach method.

This requires #1380 to go in first.

src/WinRT.Runtime/ComWrappersSupport.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ComWrappersSupport.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ComWrappersSupport.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ObjectReference.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ObjectReference.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ObjectReference.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ObjectReference.cs Outdated Show resolved Hide resolved
@jlaanstra jlaanstra force-pushed the user/jlaans/simplify-context branch from a26a5ce to 872a720 Compare November 21, 2023 00:24
@jlaanstra jlaanstra force-pushed the user/jlaans/simplify-context branch from 8330c21 to a27eded Compare January 20, 2024 04:43
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another pass, looks good! Just left a couple notes 🙂

src/WinRT.Runtime/ComWrappersSupport.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ObjectReference.cs Outdated Show resolved Hide resolved
src/WinRT.Runtime/ObjectReference.cs Outdated Show resolved Hide resolved
@jlaanstra jlaanstra force-pushed the user/jlaans/simplify-context branch from 60c087f to 7fa4c6a Compare January 23, 2024 03:08
@jlaanstra jlaanstra force-pushed the user/jlaans/simplify-context branch from a463c59 to d6671e8 Compare January 23, 2024 21:36
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@Sergio0694 Sergio0694 self-requested a review January 24, 2024 03:16
@jlaanstra jlaanstra merged commit ddd77c9 into microsoft:staging/AOT Jan 24, 2024
1 check passed
@jlaanstra jlaanstra deleted the user/jlaans/simplify-context branch January 24, 2024 19:40
@jlaanstra jlaanstra restored the user/jlaans/simplify-context branch January 24, 2024 20:05
@jlaanstra jlaanstra deleted the user/jlaans/simplify-context branch January 24, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants