Add Context checks to factory caching and simplify factory caching between factories and statics. #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween factories and statics.
Sergio0694
reviewed
Oct 22, 2023
| { | ||
| [DllImport("api-ms-win-core-com-l1-1-0.dll")] | ||
| private static extern unsafe int CoGetContextToken(IntPtr* contextToken); | ||
|
|
||
| [DllImport("api-ms-win-core-com-l1-1-0.dll")] | ||
| private static extern int CoGetObjectContext(ref Guid riid, out IntPtr ppv); |
There was a problem hiding this comment.
Same note as in the other PR, could you make this use a blittable signature while at it?
jlaanstra
force-pushed
the
user/jlaans/1112-4
branch
from
52fb3e5 to
73d5e29
Compare
Sergio0694
reviewed
Nov 3, 2023
| #if NET | ||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2091:RequiresUnreferencedCode", | ||
| Justification = "No members of the generic type are dynamically accessed in this code path.")] | ||
| #endif | ||
| public static ObjectReference<I> ActivateInstance< | ||
| #if NET | ||
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.None)] |
There was a problem hiding this comment.
Is this actually needed? Isn't I already not annotated for any dynamic access in this context? 🤔
| @@ -491,7 +568,8 @@ public BaseActivationFactory(string typeNamespace, string typeFullName) | |||
| public unsafe ObjectReference<I> _ActivateInstance<I>() | |||
There was a problem hiding this comment.
Also double checking: I see you removed the [UnconditionalSuppressMessage] below. Is this one still needed or can it also be removed after the other changes you did?
Sergio0694
reviewed
Nov 3, 2023
Sergio0694
reviewed
Nov 4, 2023
| % | ||
| internal static % Instance => _instance; | ||
| } | ||
| private static % _% = new %("%.%", %.IID); |
There was a problem hiding this comment.
Is this ever reassigned at runtime? If not, shouldn't this be readonly to improve codegen?
| { | ||
| auto class_type_name = classType.TypeName(); | ||
| w.write(R"( | ||
| private static BaseActivationFactory _%Factory = new BaseActivationFactory("%.%"); |
There was a problem hiding this comment.
Same for this one, shouldn't it be readonly, or could this ever be reassigned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation that maintains static classes compared to #1359