Fix the tooling incompatible issue with NativeAOT #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hez2010
changed the title
manodasanW
approved these changes
Jun 26, 2023
|
Thanks @hez2010, looks good to me. Will merge after the CI pipelines are done. |
dongle-the-gadget
pushed a commit
to dongle-the-gadget/CsWinRT
that referenced
this pull request
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An RVA field within a generic type is not expressible with C#, and the NativeAOT compiler doesn't support such IL at all.
To resolve this issue, we can simply move IIDDataField out of the generic types instead of nesting the data inside of a generic type.
Unblocks the tooling issue to make sure ilc can compile CsWinRT projection assemblies.
After this PR is merged, we can finally start investigating what is missing for NativeAOT-compatible.
Fixes dotnet/runtime#68278
/cc: @manodasanW @jkotas @MichalStrehovsky