Fix issue with ABI delegates in collections for .NET Standard projection #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NET standard projections
jamespik
approved these changes
Jun 8, 2023
| } | ||
|
|
||
| [Fact] | ||
| public void Test6() |
There was a problem hiding this comment.
Nit: We should improve the naming of these tests in the future
dongle-the-gadget
pushed a commit
to dongle-the-gadget/CsWinRT
that referenced
this pull request
Jul 29, 2023
…ion (microsoft#1330) * Most of the changes to remove use of Expression.GetDelegateType for .NET standard projections * Fix build * Address issues to get test passing * Fix tests * Rearranage which files the delegates are generated in and scoping it to .NET Standard * Add tests * Enable test for Net Framework * Scope delegates to NET Standard * Update UnitTestEmbedded.csproj * Handle edge case of generic type referencing another generic type. * Minor clarifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our .NET Standard embedded projection can be used with both .NET core and .NET Framework. But it seems our generic collection types runs into issues with the latter due to using
Expression.GetDelegateTypeto generate custom delegates withvoid*parameters doesn't seem to be supported there. To address that, in our .NET Standard projection, we are now code generating all the ABI delegates that we can detect as being needed while generating the projection. This is then used by the collection types for when they need the delegate via a lookup mechanism. There is a fallback toExpression.GetDelegateTypewhich handles the scenario where we couldn't detect a certain ABI delegate is needed and didn't generate it as the WinRT boundary takes the value as anobject. .NET Core users would be handled via that fallback, but .NET Framework users would see an error. In those cases, there is a way for the app to declare their own ABI delegates and register them if needed.