Fix interface name returned for GetRuntimeClassName and fix build #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwalchadha
approved these changes
Jan 31, 2023
dongle-the-gadget
pushed a commit
to dongle-the-gadget/CsWinRT
that referenced
this pull request
Jul 29, 2023
…crosoft#1290) * Fix interface name returned in GetRuntimeClassName * Fix build * Try build fix * Update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a non-WinRT C# class which we need to return the runtime class name for, we go through all the WinRT interfaces and decide on one of them to use as we can only return one. As part of this, we try to see if an interface implements the others and if so, we try to choose the one which implements the other interfaces. The logic to check this was previously incorrect and chose the child interface rather than the parent.