Replace . with _ when generating authored component's targets. #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
approved these changes
Nov 28, 2022
dongle-the-gadget
pushed a commit
to dongle-the-gadget/CsWinRT
that referenced
this pull request
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of CsWinRT Authoring may choose to create a NuPkg for their component. We have some automation tools for this scenario which generate a targets file for the project/nupkg to help with the custom build logic necessary for authored components.
Today the generated targets file uses the authoring project's AssemblyName, but fails to consider if that includes
..E.g. AssemblyName = Microsoft.Coords vs. AssemblyName = Coords.
This oversight caused build failures because MSBuild targets cannot have
.in their name.The fix is to make sure the generated file replaces
.with_when generating target names.Fixes #1229
I tested this with a sample authoring component and confirmed the targets' names change to valid format for MSBuild.