Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up .NET 5 references and update to WinAppSDK projection for testing #1261

Merged
merged 13 commits into from
Oct 25, 2022

Conversation

manodasanW
Copy link
Member

@manodasanW manodasanW commented Oct 25, 2022

  • Build pipelines recently started failing due to the x86 version of .NET 5 doesn't seem to be installed by default anymore. I took that opportunity to clean up the .NET 5 references we had rather than doing a manual install. This should also help improve our build times given we are building one less TFM.
  • One of the things blocking the cleanup of the .NET 5 TFM was we still used the old WinUI packages for our testing and they ran into build issues with .NET 6. This PR moves us to using a recent version of WinAppSDK for testing which does build without issues and also addresses the breaking changes from the old WinUI packages to WinAppSDK. We still build a projection for the old version to help with catching any regressions.
  • Fixing issue with build.cmd after one of the previous PRs

Fixes #778

Copy link
Contributor

@j0shuams j0shuams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manodasanW manodasanW merged commit 2a4876a into master Oct 25, 2022
@manodasanW manodasanW deleted the user/mawign/net5tfm branch October 25, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update repo to build and test against Windows App SDK
2 participants